-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install #18
pip install #18
Conversation
I also plan to work on the LKH part. This should be easy if we use https://github.com/fikisipi/elkai. |
After using
|
Wow. Many thanks! I just wanted to acknowledge that I've seen the PR and will look forward to reviewing it as soon as possible. I'm currently drowning in teaching and other dev work, so I'll have to look into this a bit later. But I will. I promise! |
Thanks! Take your time :) |
I have finally reviewed the code and integrated the changes. Sorry it took so long! Because the master branch had already moved on, I merged the changes manually. I'm not a git wizard, so please excuse me @chkwon if I did something wrong in merging the PR. The git log shows you as the author of those commits, so I guess I did something right... :) Regarding the |
I think all look good! Thanks. I understand your point about the license issue. It makes sense. |
Just another quick update regarding this.
I removed the orderedset dependency. Now there should be no reason why VeRyPy would not work on newer Python 3.X versions. While at it I also removed natsort dependency. I think llist could be removed as well, but perhaps it is best to leave that as an exercise of another day (or person!). Again, many thanks @chkwon for your contribution and inspiring me to do something to improve VeRyPy. |
Happy to work on this. Just one thing to consider. If you like to add to PyPI, then you might need to change the name of the package, or at least the installation name. There is something called VeryPy already: https://pypi.org/project/VeryPy/ |
This PR addresses #2
You would be able to install this package by
To test this PR:
Then,
I have tested this with Python 3.8 on mac.